diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-05-14 11:32:56 +0300 |
|---|---|---|
| committer | Luis Henriques <luis.henriques@canonical.com> | 2015-07-15 10:01:16 +0100 |
| commit | 60cd4380bd8034e30d6f4138263be597fbe70f43 (patch) | |
| tree | 1a1da5e8117e1cf89b3d0ad8b0d7ce08d4ba6ef0 /drivers/hid | |
| parent | 4742814a9e1a59953bc47328b608d6285298e753 (diff) | |
| download | linux-stable-60cd4380bd8034e30d6f4138263be597fbe70f43.tar.gz linux-stable-60cd4380bd8034e30d6f4138263be597fbe70f43.tar.bz2 linux-stable-60cd4380bd8034e30d6f4138263be597fbe70f43.zip | |
HID: rmi: fix some harmless BIT() mistakes
commit af43c4086cf24c3eb74a968195351163750c82b6 upstream.
These defines are used like this:
if (!(test_bit(RMI_STARTED, &hdata->flags)))
So the intent was to use bits 0, 1 and 2 but because of the extra BIT()
shifts we're actually using 1, 2 and 4. It's harmless because it's done
consistently but static checkers will complain.
Fixes: 9fb6bf02e3ad ('HID: rmi: introduce RMI driver for Synaptics touchpads')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Diffstat (limited to 'drivers/hid')
| -rw-r--r-- | drivers/hid/hid-rmi.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c index 53df21735cea..bedc1acd0c4a 100644 --- a/drivers/hid/hid-rmi.c +++ b/drivers/hid/hid-rmi.c @@ -29,9 +29,9 @@ #define RMI_SET_RMI_MODE_REPORT_ID 0x0f /* Feature Report */ /* flags */ -#define RMI_READ_REQUEST_PENDING BIT(0) -#define RMI_READ_DATA_PENDING BIT(1) -#define RMI_STARTED BIT(2) +#define RMI_READ_REQUEST_PENDING 0 +#define RMI_READ_DATA_PENDING 1 +#define RMI_STARTED 2 enum rmi_mode_type { RMI_MODE_OFF = 0, |