summaryrefslogtreecommitdiffstats
path: root/drivers/hwmon/jc42.c
diff options
context:
space:
mode:
authorYang Yingliang <yangyingliang@huawei.com>2022-10-27 14:29:31 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-12-31 13:33:06 +0100
commit48c509f3f1210d3a2011e7fd4bae6dfc781c5243 (patch)
tree1afa2da628d8ed83de758fa0c2076f0cb5eb507f /drivers/hwmon/jc42.c
parent0cd303aad220fafa595e0ed593e99aa51b90412b (diff)
downloadlinux-stable-48c509f3f1210d3a2011e7fd4bae6dfc781c5243.tar.gz
linux-stable-48c509f3f1210d3a2011e7fd4bae6dfc781c5243.tar.bz2
linux-stable-48c509f3f1210d3a2011e7fd4bae6dfc781c5243.zip
hwmon: (jc42) Fix missing unlock on error in jc42_write()
[ Upstream commit b744db17abf6a2efc2bfa80870cc88e9799a8ccc ] Add the missing unlock before return from function jc42_write() in the error handling case. Fixes: 37dedaee8bc6 ("hwmon: (jc42) Convert register access and caching to regmap/regcache") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Link: https://lore.kernel.org/r/20221027062931.598247-1-yangyingliang@huawei.com Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/hwmon/jc42.c')
-rw-r--r--drivers/hwmon/jc42.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
index 0554b41c32bc..6593d81cb901 100644
--- a/drivers/hwmon/jc42.c
+++ b/drivers/hwmon/jc42.c
@@ -350,7 +350,7 @@ static int jc42_write(struct device *dev, enum hwmon_sensor_types type,
ret = regmap_read(data->regmap, JC42_REG_TEMP_CRITICAL,
&regval);
if (ret)
- return ret;
+ break;
/*
* JC42.4 compliant chips only support four hysteresis values.