diff options
| author | Sergey Shtylyov <s.shtylyov@omprussia.ru> | 2021-04-10 23:16:41 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-05-22 10:59:36 +0200 |
| commit | f73b75f717fc292d7be5b32c0f8013e9dbcc4a53 (patch) | |
| tree | b8fa9b3d0b46734973ad338e34d16fcb9d4553b2 /drivers/i2c/busses | |
| parent | 92a5d9ce2d6fd85d5f8c9ef51a20133bc19226b8 (diff) | |
| download | linux-stable-f73b75f717fc292d7be5b32c0f8013e9dbcc4a53.tar.gz linux-stable-f73b75f717fc292d7be5b32c0f8013e9dbcc4a53.tar.bz2 linux-stable-f73b75f717fc292d7be5b32c0f8013e9dbcc4a53.zip | |
i2c: emev2: add IRQ check
[ Upstream commit bb6129c32867baa7988f7fd2066cf18ed662d240 ]
The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to devm_request_irq() (which
takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding
an original error code. Stop calling devm_request_irq() with invalid
IRQ #s.
Fixes: 5faf6e1f58b4 ("i2c: emev2: add driver")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/i2c/busses')
| -rw-r--r-- | drivers/i2c/busses/i2c-emev2.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/i2c/busses/i2c-emev2.c b/drivers/i2c/busses/i2c-emev2.c index 959d4912ec0d..0230a13a6ab7 100644 --- a/drivers/i2c/busses/i2c-emev2.c +++ b/drivers/i2c/busses/i2c-emev2.c @@ -397,7 +397,10 @@ static int em_i2c_probe(struct platform_device *pdev) em_i2c_reset(&priv->adap); - priv->irq = platform_get_irq(pdev, 0); + ret = platform_get_irq(pdev, 0); + if (ret < 0) + goto err_clk; + priv->irq = ret; ret = devm_request_irq(&pdev->dev, priv->irq, em_i2c_irq_handler, 0, "em_i2c", priv); if (ret) |