diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-03-08 08:21:52 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-12-25 14:23:41 +0100 |
| commit | 2f0e39f2e3d77eb086995a99c8361d7f13020120 (patch) | |
| tree | d2279aa99abb953012af2f98be595de0a3f33351 /drivers/infiniband | |
| parent | 7f077afe94d90bae3262da5e39ba75e40f9c4607 (diff) | |
| download | linux-stable-2f0e39f2e3d77eb086995a99c8361d7f13020120.tar.gz linux-stable-2f0e39f2e3d77eb086995a99c8361d7f13020120.tar.bz2 linux-stable-2f0e39f2e3d77eb086995a99c8361d7f13020120.zip | |
IB/rxe: double free on error
[ Upstream commit ded260235308f340b979258a4c736e06ba12c747 ]
"goto err;" has it's own kfree_skb() call so it's a double free. We
only need to free on the "goto exit;" path.
Fixes: 8700e3e7c485 ("Soft RoCE driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/infiniband')
| -rw-r--r-- | drivers/infiniband/sw/rxe/rxe_req.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c index 9d084780ac91..5b0ca35c06ab 100644 --- a/drivers/infiniband/sw/rxe/rxe_req.c +++ b/drivers/infiniband/sw/rxe/rxe_req.c @@ -726,11 +726,11 @@ next_wqe: ret = rxe_xmit_packet(to_rdev(qp->ibqp.device), qp, &pkt, skb); if (ret) { qp->need_req_skb = 1; - kfree_skb(skb); rollback_state(wqe, qp, &rollback_wqe, rollback_psn); if (ret == -EAGAIN) { + kfree_skb(skb); rxe_run_task(&qp->req.task, 1); goto exit; } |