diff options
| author | Pan Bian <bianpan2016@163.com> | 2017-04-23 18:23:21 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-07-05 14:35:15 +0200 |
| commit | fbb7b439df6d8b58ebeee8983add85abd28fbfcf (patch) | |
| tree | ff887c4a91cc410cfadad71f75ae235e1e0ca031 /drivers/iommu | |
| parent | cfeac3d9137d31716848a4af51ea463831c2fc4a (diff) | |
| download | linux-stable-fbb7b439df6d8b58ebeee8983add85abd28fbfcf.tar.gz linux-stable-fbb7b439df6d8b58ebeee8983add85abd28fbfcf.tar.bz2 linux-stable-fbb7b439df6d8b58ebeee8983add85abd28fbfcf.zip | |
iommu/amd: Fix incorrect error handling in amd_iommu_bind_pasid()
commit 73dbd4a4230216b6a5540a362edceae0c9b4876b upstream.
In function amd_iommu_bind_pasid(), the control flow jumps
to label out_free when pasid_state->mm and mm is NULL. And
mmput(mm) is called. In function mmput(mm), mm is
referenced without validation. This will result in a NULL
dereference bug. This patch fixes the bug.
Signed-off-by: Pan Bian <bianpan2016@163.com>
Fixes: f0aac63b873b ('iommu/amd: Don't hold a reference to mm_struct')
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/iommu')
| -rw-r--r-- | drivers/iommu/amd_iommu_v2.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/amd_iommu_v2.c b/drivers/iommu/amd_iommu_v2.c index 90d734bbf467..f0a3d505dc62 100644 --- a/drivers/iommu/amd_iommu_v2.c +++ b/drivers/iommu/amd_iommu_v2.c @@ -701,9 +701,9 @@ out_clear_state: out_unregister: mmu_notifier_unregister(&pasid_state->mn, mm); + mmput(mm); out_free: - mmput(mm); free_pasid_state(pasid_state); out: |