summaryrefslogtreecommitdiffstats
path: root/drivers/md
diff options
context:
space:
mode:
authorColy Li <colyli@suse.de>2019-04-30 22:02:25 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-10-01 08:26:09 +0200
commitad16dfef4a44ba71580af6e5cdc743c4796768ef (patch)
treefd3744ee8bac9ae0776415ad75f06c57c8131e53 /drivers/md
parent08fdaee2d97bdd55e03308b563783b2612670e8b (diff)
downloadlinux-stable-ad16dfef4a44ba71580af6e5cdc743c4796768ef.tar.gz
linux-stable-ad16dfef4a44ba71580af6e5cdc743c4796768ef.tar.bz2
linux-stable-ad16dfef4a44ba71580af6e5cdc743c4796768ef.zip
bcache: remove redundant LIST_HEAD(journal) from run_cache_set()
[ Upstream commit cdca22bcbc64fc83dadb8d927df400a8d86ddabb ] Commit 95f18c9d1310 ("bcache: avoid potential memleak of list of journal_replay(s) in the CACHE_SYNC branch of run_cache_set") forgets to remove the original define of LIST_HEAD(journal), which makes the change no take effect. This patch removes redundant variable LIST_HEAD(journal) from run_cache_set(), to make Shenghui's fix working. Fixes: 95f18c9d1310 ("bcache: avoid potential memleak of list of journal_replay(s) in the CACHE_SYNC branch of run_cache_set") Reported-by: Juha Aatrokoski <juha.aatrokoski@aalto.fi> Cc: Shenghui Wang <shhuiw@foxmail.com> Signed-off-by: Coly Li <colyli@suse.de> Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/md')
-rw-r--r--drivers/md/bcache/super.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index e6c7a84bb1df..2321643974da 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1768,7 +1768,6 @@ static int run_cache_set(struct cache_set *c)
set_gc_sectors(c);
if (CACHE_SYNC(&c->sb)) {
- LIST_HEAD(journal);
struct bkey *k;
struct jset *j;