diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2018-08-02 11:27:21 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-08-02 10:42:25 +0200 |
| commit | c01513b4b29953e6ba8a8d8de77fb5ca2f01c48f (patch) | |
| tree | 6f10a8a14409e5abf33d50d4ff478054a1bc13a7 /drivers/misc/eeprom | |
| parent | 81ae962d7f180c0092859440c82996cccb254976 (diff) | |
| download | linux-stable-c01513b4b29953e6ba8a8d8de77fb5ca2f01c48f.tar.gz linux-stable-c01513b4b29953e6ba8a8d8de77fb5ca2f01c48f.tar.bz2 linux-stable-c01513b4b29953e6ba8a8d8de77fb5ca2f01c48f.zip | |
eeprom: idt_89hpesx: clean up an error pointer vs NULL inconsistency
We check for IS_ERR_OR_NULL() here, but later we check the same thing
for NULL only. It turns out that it can only be NULL so we can make the
checking consistent by removing the ERR_PTR stuff.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/eeprom')
| -rw-r--r-- | drivers/misc/eeprom/idt_89hpesx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c index 119eb05a5a91..8a4659518c33 100644 --- a/drivers/misc/eeprom/idt_89hpesx.c +++ b/drivers/misc/eeprom/idt_89hpesx.c @@ -1128,7 +1128,7 @@ static void idt_get_fw_data(struct idt_89hpesx_dev *pdev) device_for_each_child_node(dev, fwnode) { ee_id = idt_ee_match_id(fwnode); - if (IS_ERR_OR_NULL(ee_id)) { + if (!ee_id) { dev_warn(dev, "Skip unsupported EEPROM device"); continue; } else |