summaryrefslogtreecommitdiffstats
path: root/drivers/misc/mei/amthif.c
diff options
context:
space:
mode:
authorAlexander Usyskin <alexander.usyskin@intel.com>2016-04-17 12:16:04 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-04-30 14:08:08 -0700
commit9d04ee11db7bf0d848266cbfd7db336097a0e239 (patch)
tree560ac736e47c93b2cc1273a76c45ec3c70fe6d87 /drivers/misc/mei/amthif.c
parent6a8d648c8d1824117a9e9edb948ed1611fb013c0 (diff)
downloadlinux-stable-9d04ee11db7bf0d848266cbfd7db336097a0e239.tar.gz
linux-stable-9d04ee11db7bf0d848266cbfd7db336097a0e239.tar.bz2
linux-stable-9d04ee11db7bf0d848266cbfd7db336097a0e239.zip
mei: amthif: discard not read messages
When a message is received and amthif client is not in reading state the message is ignored and left dangling in the queue. This may happen after one of the amthif host connections is closed w/o completing the reading. Another client will pick up a wrong message on next read attempt which will lead to link reset. To prevent this the driver has to properly discard the message when amthif client is not in reading state. Cc: <stable@vger.kernel.org> #4.2+ Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/mei/amthif.c')
-rw-r--r--drivers/misc/mei/amthif.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/misc/mei/amthif.c b/drivers/misc/mei/amthif.c
index 194360a5f782..a039a5df6f21 100644
--- a/drivers/misc/mei/amthif.c
+++ b/drivers/misc/mei/amthif.c
@@ -380,8 +380,10 @@ int mei_amthif_irq_read_msg(struct mei_cl *cl,
dev = cl->dev;
- if (dev->iamthif_state != MEI_IAMTHIF_READING)
+ if (dev->iamthif_state != MEI_IAMTHIF_READING) {
+ mei_irq_discard_msg(dev, mei_hdr);
return 0;
+ }
ret = mei_cl_irq_read_msg(cl, mei_hdr, cmpl_list);
if (ret)