diff options
author | Heiner Kallweit <hkallweit1@gmail.com> | 2017-11-24 07:47:50 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-12-05 11:20:46 +0100 |
commit | 165a3c7d786e16dc4a84403b73d18dac9ea97f7d (patch) | |
tree | 4e5c0e06c71708f52e2b4a9cb3764ca69bd5804f /drivers/misc | |
parent | 092b0115002b27fdbea3026bd18a6481fe67a50d (diff) | |
download | linux-stable-165a3c7d786e16dc4a84403b73d18dac9ea97f7d.tar.gz linux-stable-165a3c7d786e16dc4a84403b73d18dac9ea97f7d.tar.bz2 linux-stable-165a3c7d786e16dc4a84403b73d18dac9ea97f7d.zip |
eeprom: at24: check at24_read/write arguments
commit d9bcd462daf34aebb8de9ad7f76de0198bb5a0f0 upstream.
So far we completely rely on the caller to provide valid arguments.
To be on the safe side perform an own sanity check.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc')
-rw-r--r-- | drivers/misc/eeprom/at24.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index d87f77f790d6..c1cceeaf9aeb 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -274,6 +274,9 @@ static ssize_t at24_read(struct at24_data *at24, if (unlikely(!count)) return count; + if (off + count > at24->chip.byte_len) + return -EINVAL; + /* * Read data from chip, protecting against concurrent updates * from this host, but not from other I2C masters. @@ -328,6 +331,9 @@ static ssize_t at24_eeprom_write(struct at24_data *at24, const char *buf, unsigned long timeout, write_time; unsigned next_page; + if (offset + count > at24->chip.byte_len) + return -EINVAL; + /* Get corresponding I2C address and adjust offset */ client = at24_translate_offset(at24, &offset); |