diff options
| author | ruanjinjie <ruanjinjie@huawei.com> | 2022-11-17 14:47:25 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-01-18 09:26:24 +0100 |
| commit | d861b7d41b17942b337d4b87a70de7cd1dc44d4e (patch) | |
| tree | 7305d024534c2347aef01af9446f0a2a707c9d09 /drivers/misc | |
| parent | ed5cbafaf7ce8b86f19998c00eb020c8d49b017f (diff) | |
| download | linux-stable-d861b7d41b17942b337d4b87a70de7cd1dc44d4e.tar.gz linux-stable-d861b7d41b17942b337d4b87a70de7cd1dc44d4e.tar.bz2 linux-stable-d861b7d41b17942b337d4b87a70de7cd1dc44d4e.zip | |
misc: tifm: fix possible memory leak in tifm_7xx1_switch_media()
[ Upstream commit fd2c930cf6a5b9176382c15f9acb1996e76e25ad ]
If device_register() returns error in tifm_7xx1_switch_media(),
name of kobject which is allocated in dev_set_name() called in device_add()
is leaked.
Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized.
Fixes: 2428a8fe2261 ("tifm: move common device management tasks from tifm_7xx1 to tifm_core")
Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20221117064725.3478402-1-ruanjinjie@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/misc')
| -rw-r--r-- | drivers/misc/tifm_7xx1.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/tifm_7xx1.c b/drivers/misc/tifm_7xx1.c index e5f108713dd8..2afb96598f61 100644 --- a/drivers/misc/tifm_7xx1.c +++ b/drivers/misc/tifm_7xx1.c @@ -194,7 +194,7 @@ static void tifm_7xx1_switch_media(struct work_struct *work) spin_unlock_irqrestore(&fm->lock, flags); } if (sock) - tifm_free_device(&sock->dev); + put_device(&sock->dev); } spin_lock_irqsave(&fm->lock, flags); } |