diff options
| author | Liang He <windhl@126.com> | 2022-07-19 17:52:16 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-08-25 11:15:18 +0200 |
| commit | 3370afda701f3944e61a39881f05446dc4811008 (patch) | |
| tree | 8b43f30e8d34989fafdf7c59154c040eeb2ea4d5 /drivers/mmc/host | |
| parent | d4271c615ca0dfe5b9a3e4e591d7dc47e7ae15d2 (diff) | |
| download | linux-stable-3370afda701f3944e61a39881f05446dc4811008.tar.gz linux-stable-3370afda701f3944e61a39881f05446dc4811008.tar.bz2 linux-stable-3370afda701f3944e61a39881f05446dc4811008.zip | |
mmc: cavium-thunderx: Add of_node_put() when breaking out of loop
[ Upstream commit 7ee480795e41db314f2c445c65ed854a5d6e8e32 ]
In thunder_mmc_probe(), we should call of_node_put() when breaking
out of for_each_child_of_node() which has increased and decreased
the refcount during each iteration.
Fixes: 166bac38c3c5 ("mmc: cavium: Add MMC PCI driver for ThunderX SOCs")
Signed-off-by: Liang He <windhl@126.com>
Acked-by: Robert Richter <rric@kernel.org>
Link: https://lore.kernel.org/r/20220719095216.1241601-2-windhl@126.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/mmc/host')
| -rw-r--r-- | drivers/mmc/host/cavium-thunderx.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/mmc/host/cavium-thunderx.c b/drivers/mmc/host/cavium-thunderx.c index eee08d81b242..f79806e31e7e 100644 --- a/drivers/mmc/host/cavium-thunderx.c +++ b/drivers/mmc/host/cavium-thunderx.c @@ -138,8 +138,10 @@ static int thunder_mmc_probe(struct pci_dev *pdev, continue; ret = cvm_mmc_of_slot_probe(&host->slot_pdev[i]->dev, host); - if (ret) + if (ret) { + of_node_put(child_node); goto error; + } } i++; } |