diff options
| author | Zheyu Ma <zheyuma97@gmail.com> | 2022-08-30 15:34:50 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-10-26 13:19:27 +0200 |
| commit | 5bc20bafcd87ba0858ab772cefc7047cb51bc249 (patch) | |
| tree | 812323b13727976e98390b4e564fc5e0c195a467 /drivers/mmc/host | |
| parent | 01dbdaa0f9d3a2bedce1231e08be0519b217a148 (diff) | |
| download | linux-stable-5bc20bafcd87ba0858ab772cefc7047cb51bc249.tar.gz linux-stable-5bc20bafcd87ba0858ab772cefc7047cb51bc249.tar.bz2 linux-stable-5bc20bafcd87ba0858ab772cefc7047cb51bc249.zip | |
drm/bridge: megachips: Fix a null pointer dereference bug
[ Upstream commit 1ff673333d46d2c1b053ebd0c1c7c7c79e36943e ]
When removing the module we will get the following warning:
[ 31.911505] i2c-core: driver [stdp2690-ge-b850v3-fw] unregistered
[ 31.912484] general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] PREEMPT SMP KASAN PTI
[ 31.913338] KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f]
[ 31.915280] RIP: 0010:drm_bridge_remove+0x97/0x130
[ 31.921825] Call Trace:
[ 31.922533] stdp4028_ge_b850v3_fw_remove+0x34/0x60 [megachips_stdpxxxx_ge_b850v3_fw]
[ 31.923139] i2c_device_remove+0x181/0x1f0
The two bridges (stdp2690, stdp4028) do not probe at the same time, so
the driver does not call ge_b850v3_resgiter() when probing, causing the
driver to try to remove the object that has not been initialized.
Fix this by checking whether both the bridges are probed.
Fixes: 11632d4aa2b3 ("drm/bridge: megachips: Ensure both bridges are probed before registration")
Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220830073450.1897020-1-zheyuma97@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/mmc/host')
0 files changed, 0 insertions, 0 deletions