diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2020-02-28 12:25:54 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-04-23 10:36:45 +0200 |
| commit | 4191ebe1fc71b6343c9d72b4de6e408c8d0b03bd (patch) | |
| tree | 574e1702322038c1ae69f2f9743d3d1c22619ebe /drivers/mtd/lpddr/lpddr_cmds.c | |
| parent | 7d4adb1d3c69efb1d0d90161cdea75b8dcae80a6 (diff) | |
| download | linux-stable-4191ebe1fc71b6343c9d72b4de6e408c8d0b03bd.tar.gz linux-stable-4191ebe1fc71b6343c9d72b4de6e408c8d0b03bd.tar.bz2 linux-stable-4191ebe1fc71b6343c9d72b4de6e408c8d0b03bd.zip | |
mtd: lpddr: Fix a double free in probe()
commit 4da0ea71ea934af18db4c63396ba2af1a679ef02 upstream.
This function is only called from lpddr_probe(). We free "lpddr" both
here and in the caller, so it's a double free. The best place to free
"lpddr" is in lpddr_probe() so let's delete this one.
Fixes: 8dc004395d5e ("[MTD] LPDDR qinfo probing.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200228092554.o57igp3nqhyvf66t@kili.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/mtd/lpddr/lpddr_cmds.c')
| -rw-r--r-- | drivers/mtd/lpddr/lpddr_cmds.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/mtd/lpddr/lpddr_cmds.c b/drivers/mtd/lpddr/lpddr_cmds.c index 1efc643c9871..9341a8a592e8 100644 --- a/drivers/mtd/lpddr/lpddr_cmds.c +++ b/drivers/mtd/lpddr/lpddr_cmds.c @@ -68,7 +68,6 @@ struct mtd_info *lpddr_cmdset(struct map_info *map) shared = kmalloc_array(lpddr->numchips, sizeof(struct flchip_shared), GFP_KERNEL); if (!shared) { - kfree(lpddr); kfree(mtd); return NULL; } |