diff options
| author | Doug Berger <opendmb@gmail.com> | 2020-04-23 16:13:30 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-04-24 16:50:01 -0700 |
| commit | 3554e54a46125030c534820c297ed7f6c3907e24 (patch) | |
| tree | 853f2832bbf93ac925133d23ac91b9cb6da6aa04 /drivers/net/ethernet/broadcom/bcmsysport.c | |
| parent | ecaeceb8a8a145d93c7e136f170238229165348f (diff) | |
| download | linux-stable-3554e54a46125030c534820c297ed7f6c3907e24.tar.gz linux-stable-3554e54a46125030c534820c297ed7f6c3907e24.tar.bz2 linux-stable-3554e54a46125030c534820c297ed7f6c3907e24.zip | |
net: systemport: suppress warnings on failed Rx SKB allocations
The driver is designed to drop Rx packets and reclaim the buffers
when an allocation fails, and the network interface needs to safely
handle this packet loss. Therefore, an allocation failure of Rx
SKBs is relatively benign.
However, the output of the warning message occurs with a high
scheduling priority that can cause excessive jitter/latency for
other high priority processing.
This commit suppresses the warning messages to prevent scheduling
problems while retaining the failure count in the statistics of
the network interface.
Signed-off-by: Doug Berger <opendmb@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/bcmsysport.c')
| -rw-r--r-- | drivers/net/ethernet/broadcom/bcmsysport.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c index c99e5a3fa746..b25356e21a1e 100644 --- a/drivers/net/ethernet/broadcom/bcmsysport.c +++ b/drivers/net/ethernet/broadcom/bcmsysport.c @@ -664,7 +664,8 @@ static struct sk_buff *bcm_sysport_rx_refill(struct bcm_sysport_priv *priv, dma_addr_t mapping; /* Allocate a new SKB for a new packet */ - skb = netdev_alloc_skb(priv->netdev, RX_BUF_LENGTH); + skb = __netdev_alloc_skb(priv->netdev, RX_BUF_LENGTH, + GFP_ATOMIC | __GFP_NOWARN); if (!skb) { priv->mib.alloc_rx_buff_failed++; netif_err(priv, rx_err, ndev, "SKB alloc failed\n"); |