diff options
| author | Sascha Hauer <s.hauer@pengutronix.de> | 2020-06-24 09:00:44 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-06-24 14:51:42 -0700 |
| commit | d3d239dcb8aae6d7b10642d292b404e57604f7ea (patch) | |
| tree | 953b6125f3625cbb161dad79fabd849f0087b602 /drivers/net/ethernet/marvell | |
| parent | 1ed9ec9b08addbd8d3e36d5f4a652d8590a6ddb7 (diff) | |
| download | linux-stable-d3d239dcb8aae6d7b10642d292b404e57604f7ea.tar.gz linux-stable-d3d239dcb8aae6d7b10642d292b404e57604f7ea.tar.bz2 linux-stable-d3d239dcb8aae6d7b10642d292b404e57604f7ea.zip | |
net: ethernet: mvneta: Do not error out in non serdes modes
In mvneta_config_interface() the RGMII modes are catched by the default
case which is an error return. The RGMII modes are valid modes for the
driver, so instead of returning an error add a break statement to return
successfully.
This avoids this warning for non comphy SoCs which use RGMII, like
SolidRun Clearfog:
WARNING: CPU: 0 PID: 268 at drivers/net/ethernet/marvell/mvneta.c:3512 mvneta_start_dev+0x220/0x23c
Fixes: b4748553f53f ("net: ethernet: mvneta: Fix Serdes configuration for SoCs without comphy")
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/marvell')
| -rw-r--r-- | drivers/net/ethernet/marvell/mvneta.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index af6000172848..c4552f868157 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -3571,7 +3571,7 @@ static int mvneta_config_interface(struct mvneta_port *pp, MVNETA_HSGMII_SERDES_PROTO); break; default: - return -EINVAL; + break; } } |