diff options
| author | yuval.shaia@oracle.com <yuval.shaia@oracle.com> | 2017-06-13 10:09:46 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-06-13 12:59:06 -0400 |
| commit | 5514174fe9c61c83bd8781c1e048ea6b4bf16a14 (patch) | |
| tree | bea0cf943d500b7a6ba95506e601e7b885ec47bc /drivers/net/ethernet/renesas/ravb_main.c | |
| parent | d980b8d1fc3c6a37f1123995d3939c6b0eeff1c5 (diff) | |
| download | linux-stable-5514174fe9c61c83bd8781c1e048ea6b4bf16a14.tar.gz linux-stable-5514174fe9c61c83bd8781c1e048ea6b4bf16a14.tar.bz2 linux-stable-5514174fe9c61c83bd8781c1e048ea6b4bf16a14.zip | |
net: phy: Make phy_ethtool_ksettings_get return void
Make return value void since function never return meaningfull value
Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/renesas/ravb_main.c')
| -rw-r--r-- | drivers/net/ethernet/renesas/ravb_main.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 784782da3a85..5931e859876c 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -1076,16 +1076,16 @@ static int ravb_get_link_ksettings(struct net_device *ndev, struct ethtool_link_ksettings *cmd) { struct ravb_private *priv = netdev_priv(ndev); - int error = -ENODEV; unsigned long flags; - if (ndev->phydev) { - spin_lock_irqsave(&priv->lock, flags); - error = phy_ethtool_ksettings_get(ndev->phydev, cmd); - spin_unlock_irqrestore(&priv->lock, flags); - } + if (!ndev->phydev) + return -ENODEV; - return error; + spin_lock_irqsave(&priv->lock, flags); + phy_ethtool_ksettings_get(ndev->phydev, cmd); + spin_unlock_irqrestore(&priv->lock, flags); + + return 0; } static int ravb_set_link_ksettings(struct net_device *ndev, |