diff options
| author | Hangyu Hua <hbh25y@gmail.com> | 2022-01-24 11:29:54 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-02-08 18:23:11 +0100 |
| commit | 4bd197ce18329e3725fe3af5bd27daa4256d3ac7 (patch) | |
| tree | a460404b21fdc2b9d6898b6e43873d4c1a93a44a /drivers/net/hamradio | |
| parent | e966de190b93fb12a52d109cb928a3cd7472aca7 (diff) | |
| download | linux-stable-4bd197ce18329e3725fe3af5bd27daa4256d3ac7.tar.gz linux-stable-4bd197ce18329e3725fe3af5bd27daa4256d3ac7.tar.bz2 linux-stable-4bd197ce18329e3725fe3af5bd27daa4256d3ac7.zip | |
yam: fix a memory leak in yam_siocdevprivate()
[ Upstream commit 29eb31542787e1019208a2e1047bb7c76c069536 ]
ym needs to be free when ym->cmd != SIOCYAMSMCS.
Fixes: 0781168e23a2 ("yam: fix a missing-check bug")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/net/hamradio')
| -rw-r--r-- | drivers/net/hamradio/yam.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c index fdab49872587..3db86f247bf4 100644 --- a/drivers/net/hamradio/yam.c +++ b/drivers/net/hamradio/yam.c @@ -966,9 +966,7 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) sizeof(struct yamdrv_ioctl_mcs)); if (IS_ERR(ym)) return PTR_ERR(ym); - if (ym->cmd != SIOCYAMSMCS) - return -EINVAL; - if (ym->bitrate > YAM_MAXBITRATE) { + if (ym->cmd != SIOCYAMSMCS || ym->bitrate > YAM_MAXBITRATE) { kfree(ym); return -EINVAL; } |