diff options
author | Julia Lawall <Julia.Lawall@inria.fr> | 2020-04-30 21:51:32 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-05-14 07:58:19 +0200 |
commit | 429a8962569366dd40a251fb8da6cd4b030d0b80 (patch) | |
tree | 7203ed95329817ecabfc8533b88e4d087a31dbba /drivers/net/phy/dp83640.c | |
parent | 6ee2fdf2ba4d3423ea1c7da324a1bcdfdf823f0c (diff) | |
download | linux-stable-429a8962569366dd40a251fb8da6cd4b030d0b80.tar.gz linux-stable-429a8962569366dd40a251fb8da6cd4b030d0b80.tar.bz2 linux-stable-429a8962569366dd40a251fb8da6cd4b030d0b80.zip |
dp83640: reverse arguments to list_add_tail
[ Upstream commit 865308373ed49c9fb05720d14cbf1315349b32a9 ]
In this code, it appears that phyter_clocks is a list head, based on
the previous list_for_each, and that clock->list is intended to be a
list element, given that it has just been initialized in
dp83640_clock_init. Accordingly, switch the arguments to
list_add_tail, which takes the list head as the second argument.
Fixes: cb646e2b02b27 ("ptp: Added a clock driver for the National Semiconductor PHYTER.")
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net/phy/dp83640.c')
-rw-r--r-- | drivers/net/phy/dp83640.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c index 8f241b57fcf6..1c75b2627ca8 100644 --- a/drivers/net/phy/dp83640.c +++ b/drivers/net/phy/dp83640.c @@ -1119,7 +1119,7 @@ static struct dp83640_clock *dp83640_clock_get_bus(struct mii_bus *bus) goto out; } dp83640_clock_init(clock, bus); - list_add_tail(&phyter_clocks, &clock->list); + list_add_tail(&clock->list, &phyter_clocks); out: mutex_unlock(&phyter_clocks_lock); |