diff options
| author | Oliver Neukum <oneukum@suse.com> | 2021-10-21 14:29:44 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-11-02 18:26:43 +0100 |
| commit | 002d82227c0abe29118cf80f7e2f396b22d448ed (patch) | |
| tree | 9c6fece65b080543168ed1720cb99d34d4a7061c /drivers/net/usb/usbnet.c | |
| parent | d725978abb0bac6e0c427548dfd6db86709a2a1e (diff) | |
| download | linux-stable-002d82227c0abe29118cf80f7e2f396b22d448ed.tar.gz linux-stable-002d82227c0abe29118cf80f7e2f396b22d448ed.tar.bz2 linux-stable-002d82227c0abe29118cf80f7e2f396b22d448ed.zip | |
usbnet: sanity check for maxpacket
commit 397430b50a363d8b7bdda00522123f82df6adc5e upstream.
maxpacket of 0 makes no sense and oopses as we need to divide
by it. Give up.
V2: fixed typo in log and stylistic issues
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Reported-by: syzbot+76bb1d34ffa0adc03baa@syzkaller.appspotmail.com
Reviewed-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20211021122944.21816-1-oneukum@suse.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net/usb/usbnet.c')
| -rw-r--r-- | drivers/net/usb/usbnet.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 84b354f76dea..0598bc7aff89 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -1784,6 +1784,10 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod) if (!dev->rx_urb_size) dev->rx_urb_size = dev->hard_mtu; dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1); + if (dev->maxpacket == 0) { + /* that is a broken device */ + goto out4; + } /* let userspace know we have a random address */ if (ether_addr_equal(net->dev_addr, node_id)) |