diff options
| author | Daniel Mack <daniel@zonque.org> | 2018-05-23 11:14:55 +0300 |
|---|---|---|
| committer | Kalle Valo <kvalo@codeaurora.org> | 2018-05-25 13:08:01 +0300 |
| commit | 773f9a28bcdafd6cb77fb1afc545c62746d53990 (patch) | |
| tree | d7e6ad635a97d1b3cea5fa2b8436cb005e8684ca /drivers/net/wireless | |
| parent | 2a46c829a9266bf2a2be1a3d25dbac5fcd4eb9c1 (diff) | |
| download | linux-stable-773f9a28bcdafd6cb77fb1afc545c62746d53990.tar.gz linux-stable-773f9a28bcdafd6cb77fb1afc545c62746d53990.tar.bz2 linux-stable-773f9a28bcdafd6cb77fb1afc545c62746d53990.zip | |
wcn36xx: drain pending indicator messages on shutdown
When the interface is shut down, wcn36xx_smd_close() potentially races
against the queue worker. Make sure to cancel the work, and then free all
the remnants in hal_ind_queue manually.
This is again just a theoretical issue, not something that was triggered in
the wild.
Signed-off-by: Daniel Mack <daniel@zonque.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless')
| -rw-r--r-- | drivers/net/wireless/ath/wcn36xx/smd.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c index ea74f2b92df5..0a505b5e038b 100644 --- a/drivers/net/wireless/ath/wcn36xx/smd.c +++ b/drivers/net/wireless/ath/wcn36xx/smd.c @@ -2513,5 +2513,11 @@ out: void wcn36xx_smd_close(struct wcn36xx *wcn) { + struct wcn36xx_hal_ind_msg *msg, *tmp; + + cancel_work_sync(&wcn->hal_ind_work); destroy_workqueue(wcn->hal_ind_wq); + + list_for_each_entry_safe(msg, tmp, &wcn->hal_ind_queue, list) + kfree(msg); } |