diff options
| author | Chaitanya Kulkarni <kch@nvidia.com> | 2022-07-18 16:12:33 -0700 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2022-08-02 17:22:51 -0600 |
| commit | be2ada6d0ed094c77040dc7e2d56599dd492d961 (patch) | |
| tree | aa5ea25bd67dfa5a496ce6a8f5399e589af30663 /drivers/nvme | |
| parent | 1040415c29f065e47b6b4df9f3902602d0382d3d (diff) | |
| download | linux-stable-be2ada6d0ed094c77040dc7e2d56599dd492d961.tar.gz linux-stable-be2ada6d0ed094c77040dc7e2d56599dd492d961.tar.bz2 linux-stable-be2ada6d0ed094c77040dc7e2d56599dd492d961.zip | |
nvmet-auth: fix return value check in auth receive
nvmet_auth_challenge() return type is int and currently it uses status
variable that is of type u16 in nvmet_execute_auth_receive().
Catch the return value of nvmet_auth_challenge() into int and set the
NVME_SC_INTERNAL as status variable before we jump to error.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/target/fabrics-cmd-auth.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/nvme/target/fabrics-cmd-auth.c b/drivers/nvme/target/fabrics-cmd-auth.c index b785a8e27fa0..c851814d6cb0 100644 --- a/drivers/nvme/target/fabrics-cmd-auth.c +++ b/drivers/nvme/target/fabrics-cmd-auth.c @@ -484,8 +484,7 @@ void nvmet_execute_auth_receive(struct nvmet_req *req) ctrl->cntlid, req->sq->qid, req->sq->dhchap_step); switch (req->sq->dhchap_step) { case NVME_AUTH_DHCHAP_MESSAGE_CHALLENGE: - status = nvmet_auth_challenge(req, d, al); - if (status < 0) { + if (nvmet_auth_challenge(req, d, al) < 0) { pr_warn("ctrl %d qid %d: challenge error (%d)\n", ctrl->cntlid, req->sq->qid, status); status = NVME_SC_INTERNAL; |