diff options
author | Robin Murphy <robin.murphy@arm.com> | 2022-09-29 13:48:38 +0100 |
---|---|---|
committer | Rob Herring <robh@kernel.org> | 2022-09-30 14:35:43 -0500 |
commit | f1ad5338a4d57fe1fe6475003acb8c70bf9d1bdf (patch) | |
tree | 4e0c03ad6c6334de5bf36988639db0772fb0e018 /drivers/of/address.c | |
parent | 17005609548f1f0204cbfc988b325533470e585c (diff) | |
download | linux-stable-f1ad5338a4d57fe1fe6475003acb8c70bf9d1bdf.tar.gz linux-stable-f1ad5338a4d57fe1fe6475003acb8c70bf9d1bdf.tar.bz2 linux-stable-f1ad5338a4d57fe1fe6475003acb8c70bf9d1bdf.zip |
of: Fix "dma-ranges" handling for bus controllers
Commit 951d48855d86 ("of: Make of_dma_get_range() work on bus nodes")
relaxed the handling of "dma-ranges" for any leaf node on the assumption
that it would still represent a usage error for the property to be
present on a non-bus leaf node. However there turns out to be a fiddly
case where a bus also represents a DMA-capable device in its own right,
such as a PCIe root complex with an integrated DMA engine on its
platform side. In such cases, "dma-ranges" translation is entirely valid
for devices discovered behind the bus, but should not be erroneously
applied to the bus controller device itself which operates in its
parent's address space. Fix this by restoring the previous behaviour for
the specific case where a device is configured via its own OF node,
since it is logical to assume that a device should never represent its
own parent bus.
Reported-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/112e8f3d3e7c054ecf5e12b5ac0aa5596ec00681.1664455433.git.robin.murphy@arm.com
Signed-off-by: Rob Herring <robh@kernel.org>
Diffstat (limited to 'drivers/of/address.c')
-rw-r--r-- | drivers/of/address.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/of/address.c b/drivers/of/address.c index 96f0a12e507c..c34ac33b7338 100644 --- a/drivers/of/address.c +++ b/drivers/of/address.c @@ -579,7 +579,8 @@ u64 of_translate_address(struct device_node *dev, const __be32 *in_addr) } EXPORT_SYMBOL(of_translate_address); -static struct device_node *__of_get_dma_parent(const struct device_node *np) +#ifdef CONFIG_HAS_DMA +struct device_node *__of_get_dma_parent(const struct device_node *np) { struct of_phandle_args args; int ret, index; @@ -596,6 +597,7 @@ static struct device_node *__of_get_dma_parent(const struct device_node *np) return of_node_get(args.np); } +#endif static struct device_node *of_get_next_dma_parent(struct device_node *np) { |