summaryrefslogtreecommitdiffstats
path: root/drivers/of
diff options
context:
space:
mode:
authorNavid Emamdoost <navid.emamdoost@gmail.com>2019-10-04 13:58:43 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-11-10 11:27:30 +0100
commitfcc3f7c810c3bc595ce179ea4d9e18f506fd0d03 (patch)
treeb7d3d0c26c5d93db2dbdb7dea83b1069b348a996 /drivers/of
parentc56b9da70d0918d545db1a18c33a61284813395e (diff)
downloadlinux-stable-fcc3f7c810c3bc595ce179ea4d9e18f506fd0d03.tar.gz
linux-stable-fcc3f7c810c3bc595ce179ea4d9e18f506fd0d03.tar.bz2
linux-stable-fcc3f7c810c3bc595ce179ea4d9e18f506fd0d03.zip
of: unittest: fix memory leak in unittest_data_add
[ Upstream commit e13de8fe0d6a51341671bbe384826d527afe8d44 ] In unittest_data_add, a copy buffer is created via kmemdup. This buffer is leaked if of_fdt_unflatten_tree fails. The release for the unittest_data buffer is added. Fixes: b951f9dc7f25 ("Enabling OF selftest to run without machine's devicetree") Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> Reviewed-by: Frank Rowand <frowand.list@gmail.com> Signed-off-by: Rob Herring <robh@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/of')
-rw-r--r--drivers/of/unittest.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 7f42314da6ae..bac4b4bbc33d 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -1159,6 +1159,7 @@ static int __init unittest_data_add(void)
of_fdt_unflatten_tree(unittest_data, NULL, &unittest_data_node);
if (!unittest_data_node) {
pr_warn("%s: No tree to attach; not running tests\n", __func__);
+ kfree(unittest_data);
return -ENODATA;
}