diff options
| author | Liang He <windhl@126.com> | 2022-07-15 21:03:30 +0800 |
|---|---|---|
| committer | Will Deacon <will@kernel.org> | 2022-07-19 18:40:31 +0100 |
| commit | 491f10d08fdae10a177edf6af4f43b83b293114b (patch) | |
| tree | 9f129b3122c594259183f357722b81073316cef6 /drivers/perf | |
| parent | aaaee7b55c9e58410abcef6e3e2fd80e4135d02e (diff) | |
| download | linux-stable-491f10d08fdae10a177edf6af4f43b83b293114b.tar.gz linux-stable-491f10d08fdae10a177edf6af4f43b83b293114b.tar.bz2 linux-stable-491f10d08fdae10a177edf6af4f43b83b293114b.zip | |
perf: RISC-V: Add of_node_put() when breaking out of for_each_of_cpu_node()
In pmu_sbi_setup_irqs(), we should call of_node_put() for the 'cpu'
when breaking out of for_each_of_cput_node() as its refcount will
be automatically increased and decreased during the iteration.
Fixes: 4905ec2fb7e6 ("RISC-V: Add sscofpmf extension support")
Signed-off-by: Liang He <windhl@126.com>
Reviewed-by: Atish Patra <atishp@rivosinc.com>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Link: https://lore.kernel.org/r/20220715130330.443363-1-windhl@126.com
Signed-off-by: Will Deacon <will@kernel.org>
Diffstat (limited to 'drivers/perf')
| -rw-r--r-- | drivers/perf/riscv_pmu_sbi.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/perf/riscv_pmu_sbi.c b/drivers/perf/riscv_pmu_sbi.c index 06fefcccf379..79a3de515ece 100644 --- a/drivers/perf/riscv_pmu_sbi.c +++ b/drivers/perf/riscv_pmu_sbi.c @@ -686,12 +686,15 @@ static int pmu_sbi_setup_irqs(struct riscv_pmu *pmu, struct platform_device *pde child = of_get_compatible_child(cpu, "riscv,cpu-intc"); if (!child) { pr_err("Failed to find INTC node\n"); + of_node_put(cpu); return -ENODEV; } domain = irq_find_host(child); of_node_put(child); - if (domain) + if (domain) { + of_node_put(cpu); break; + } } if (!domain) { pr_err("Failed to find INTC IRQ root domain\n"); |