summaryrefslogtreecommitdiffstats
path: root/drivers/phy
diff options
context:
space:
mode:
authorYuan Can <yuancan@huawei.com>2022-09-24 07:02:59 +0000
committerVinod Koul <vkoul@kernel.org>2022-09-24 13:03:49 +0530
commit6d9b32fb3e432829e4f46427f334a8fc90233ef8 (patch)
tree7697dfbbbb6382c5e65eb74f66b23fdc8e2c63ca /drivers/phy
parent413e048a2e51bcc96667c711785b40cf742fb366 (diff)
downloadlinux-stable-6d9b32fb3e432829e4f46427f334a8fc90233ef8.tar.gz
linux-stable-6d9b32fb3e432829e4f46427f334a8fc90233ef8.tar.bz2
linux-stable-6d9b32fb3e432829e4f46427f334a8fc90233ef8.zip
phy: qcom-qmp-ufs: Use dev_err_probe() to simplify code
In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can <yuancan@huawei.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Andrew Halaney <ahalaney@redhat.com> Link: https://lore.kernel.org/r/20220924070300.25080-4-yuancan@huawei.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy')
-rw-r--r--drivers/phy/qualcomm/phy-qcom-qmp-ufs.c9
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
index d21b977850b3..c08d34ad1313 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
@@ -1215,12 +1215,9 @@ static int qmp_ufs_probe(struct platform_device *pdev)
return ret;
ret = qmp_ufs_vreg_init(dev, cfg);
- if (ret) {
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "failed to get regulator supplies: %d\n",
- ret);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret,
+ "failed to get regulator supplies\n");
num = of_get_available_child_count(dev->of_node);
/* do we have a rogue child node ? */