diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-01-26 12:24:25 +0300 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2016-03-02 15:18:53 -0500 |
| commit | ebd79bf31a190ed7f8090dd1007eb6026fca5246 (patch) | |
| tree | 9ef22bb601cbd7085b600c73934831b7e1ab82ea /drivers/platform | |
| parent | f67924cc39badbc813bd1935f9a025065a6a6534 (diff) | |
| download | linux-stable-ebd79bf31a190ed7f8090dd1007eb6026fca5246.tar.gz linux-stable-ebd79bf31a190ed7f8090dd1007eb6026fca5246.tar.bz2 linux-stable-ebd79bf31a190ed7f8090dd1007eb6026fca5246.zip | |
intel_scu_ipcutil: underflow in scu_reg_access()
[ Upstream commit b1d353ad3d5835b16724653b33c05124e1b5acf1 ]
"count" is controlled by the user and it can be negative. Let's prevent
that by making it unsigned. You have to have CAP_SYS_RAWIO to call this
function so the bug is not as serious as it could be.
Fixes: 5369c02d951a ('intel_scu_ipc: Utility driver for intel scu ipc')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable@vger.kernel.org
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'drivers/platform')
| -rw-r--r-- | drivers/platform/x86/intel_scu_ipcutil.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/intel_scu_ipcutil.c b/drivers/platform/x86/intel_scu_ipcutil.c index 02bc5a6343c3..aa454241489c 100644 --- a/drivers/platform/x86/intel_scu_ipcutil.c +++ b/drivers/platform/x86/intel_scu_ipcutil.c @@ -49,7 +49,7 @@ struct scu_ipc_data { static int scu_reg_access(u32 cmd, struct scu_ipc_data *data) { - int count = data->count; + unsigned int count = data->count; if (count == 0 || count == 3 || count > 4) return -EINVAL; |