summaryrefslogtreecommitdiffstats
path: root/drivers/power/supply/wm8350_power.c
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2016-10-29 21:36:57 +0200
committerSebastian Reichel <sre@kernel.org>2016-11-23 23:46:20 +0100
commit8d4124cb94c0613d79a2e3e5727b35a36497ffb7 (patch)
tree30dbf3e13796eb35f41978d129f6f162454126d6 /drivers/power/supply/wm8350_power.c
parent5ee1d39e1c2e88946ecdb204659ed34518f88ddc (diff)
downloadlinux-stable-8d4124cb94c0613d79a2e3e5727b35a36497ffb7.tar.gz
linux-stable-8d4124cb94c0613d79a2e3e5727b35a36497ffb7.tar.bz2
linux-stable-8d4124cb94c0613d79a2e3e5727b35a36497ffb7.zip
wm8350_power: use permission-specific DEVICE_ATTR variants
Use DEVICE_ATTR_RO for read only attributes. This simplifies the source code, improves readbility, and reduces the chance of inconsistencies. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @ro@ declarer name DEVICE_ATTR; identifier x,x_show; @@ DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL); @script:ocaml@ x << ro.x; x_show << ro.x_show; @@ if not (x^"_show" = x_show) then Coccilib.include_match false @@ declarer name DEVICE_ATTR_RO; identifier ro.x,ro.x_show; @@ - DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL); + DEVICE_ATTR_RO(x); // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Signed-off-by: Sebastian Reichel <sre@kernel.org>
Diffstat (limited to 'drivers/power/supply/wm8350_power.c')
-rw-r--r--drivers/power/supply/wm8350_power.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/power/supply/wm8350_power.c b/drivers/power/supply/wm8350_power.c
index 5c5880664e09..a2740cf57ad3 100644
--- a/drivers/power/supply/wm8350_power.c
+++ b/drivers/power/supply/wm8350_power.c
@@ -182,7 +182,7 @@ static ssize_t charger_state_show(struct device *dev,
return sprintf(buf, "%s\n", charge);
}
-static DEVICE_ATTR(charger_state, 0444, charger_state_show, NULL);
+static DEVICE_ATTR_RO(charger_state);
static irqreturn_t wm8350_charger_handler(int irq, void *data)
{