diff options
author | Nathan Chancellor <natechancellor@gmail.com> | 2018-10-12 19:14:58 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-10-17 21:52:40 -0700 |
commit | 8c3bf9b62b667456a57aefcf1689e826df146159 (patch) | |
tree | 72fa781c083b785755bf1415b43dc45b7331071e /drivers/ptp/ptp_chardev.c | |
parent | dc6d0f0b4340ef6814d5345dbeaa5e909395dd1d (diff) | |
download | linux-stable-8c3bf9b62b667456a57aefcf1689e826df146159.tar.gz linux-stable-8c3bf9b62b667456a57aefcf1689e826df146159.tar.bz2 linux-stable-8c3bf9b62b667456a57aefcf1689e826df146159.zip |
net: qla3xxx: Remove overflowing shift statement
Clang currently warns:
drivers/net/ethernet/qlogic/qla3xxx.c:384:24: warning: signed shift
result (0xF00000000) requires 37 bits to represent, but 'int' only has
32 bits [-Wshift-overflow]
((ISP_NVRAM_MASK << 16) | qdev->eeprom_cmd_data));
~~~~~~~~~~~~~~ ^ ~~
1 warning generated.
The warning is certainly accurate since ISP_NVRAM_MASK is defined as
(0x000F << 16) which is then shifted by 16, resulting in 64424509440,
well above UINT_MAX.
Given that this is the only location in this driver where ISP_NVRAM_MASK
is shifted again, it seems likely that ISP_NVRAM_MASK was originally
defined without a shift and during the move of the shift to the
definition, this statement wasn't properly removed (since ISP_NVRAM_MASK
is used in the statenent right above this). Only the maintainers can
confirm this since this statment has been here since the driver was
first added to the kernel.
Link: https://github.com/ClangBuiltLinux/linux/issues/127
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/ptp/ptp_chardev.c')
0 files changed, 0 insertions, 0 deletions