summaryrefslogtreecommitdiffstats
path: root/drivers/pwm
diff options
context:
space:
mode:
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>2021-07-07 18:28:29 +0200
committerThierry Reding <thierry.reding@gmail.com>2021-09-02 21:38:53 +0200
commitf0e96e2e2cb292594483b0ff3cd00b45e386c45f (patch)
tree05391f9566cd4edb65505edcc48a467356bd90bc /drivers/pwm
parentfaaa2222213b0c44e4f477c93d6f980e0156cda8 (diff)
downloadlinux-stable-f0e96e2e2cb292594483b0ff3cd00b45e386c45f.tar.gz
linux-stable-f0e96e2e2cb292594483b0ff3cd00b45e386c45f.tar.bz2
linux-stable-f0e96e2e2cb292594483b0ff3cd00b45e386c45f.zip
pwm: pca9685: Don't check the return code of pwmchip_remove()
pwmchip_remove() returns always 0. Don't use the value to make it possible to eventually change the function to return void. Also the driver core ignores the return value of pca9685_pwm_remove() and considers the device removed anyhow. So returning early results in a resource leak. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Diffstat (limited to 'drivers/pwm')
-rw-r--r--drivers/pwm/pwm-pca9685.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c
index 42ed770b432c..c56001a790d0 100644
--- a/drivers/pwm/pwm-pca9685.c
+++ b/drivers/pwm/pwm-pca9685.c
@@ -601,11 +601,8 @@ static int pca9685_pwm_probe(struct i2c_client *client,
static int pca9685_pwm_remove(struct i2c_client *client)
{
struct pca9685 *pca = i2c_get_clientdata(client);
- int ret;
- ret = pwmchip_remove(&pca->chip);
- if (ret)
- return ret;
+ pwmchip_remove(&pca->chip);
if (!pm_runtime_enabled(&client->dev)) {
/* Put chip in sleep state if runtime PM is disabled */