summaryrefslogtreecommitdiffstats
path: root/drivers/regulator/gpio-regulator.c
diff options
context:
space:
mode:
authorLee Jones <lee.jones@linaro.org>2012-11-14 11:51:36 +0000
committerMark Brown <broonie@opensource.wolfsonmicro.com>2012-11-14 20:58:09 +0900
commit216f2b9c95ac6e4f00b08df807bc4454434a9afb (patch)
tree5465802601b41d58bed5081b89c089da128d4731 /drivers/regulator/gpio-regulator.c
parentf8a9f757cb425c4784b80b001c7a77c7810b499f (diff)
downloadlinux-stable-216f2b9c95ac6e4f00b08df807bc4454434a9afb.tar.gz
linux-stable-216f2b9c95ac6e4f00b08df807bc4454434a9afb.tar.bz2
linux-stable-216f2b9c95ac6e4f00b08df807bc4454434a9afb.zip
regulator: gpio-regulator: Catch 'no states property' misuse
A selection of voltage or current values (AKA states) should always be specified when using a GPIO regulator. If there are no switchable states then the fixed regulators should be used instead. Signed-off-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'drivers/regulator/gpio-regulator.c')
-rw-r--r--drivers/regulator/gpio-regulator.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
index faa2f712eb0d..dc9260545b80 100644
--- a/drivers/regulator/gpio-regulator.c
+++ b/drivers/regulator/gpio-regulator.c
@@ -183,6 +183,11 @@ of_get_gpio_regulator_config(struct device *dev, struct device_node *np)
/* Fetch states. */
prop = of_find_property(np, "states", NULL);
+ if (!prop) {
+ dev_err(dev, "No 'states' property found\n");
+ return ERR_PTR(-EINVAL);
+ }
+
proplen = prop->length / sizeof(int);
config->states = devm_kzalloc(dev,