diff options
author | Russell King (Oracle) <rmk+kernel@armlinux.org.uk> | 2021-10-28 15:55:34 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-11-26 11:36:11 +0100 |
commit | d9a5f6a33cd29df9bf8aceda839bdbc4ba3e1152 (patch) | |
tree | 146154c7784aaa4bc18118ab5b15d51c8d504e6f /drivers/rtc/rtc-au1xxx.c | |
parent | 4123195a567a0372535ae973c97fa7cefb523e62 (diff) | |
download | linux-stable-d9a5f6a33cd29df9bf8aceda839bdbc4ba3e1152.tar.gz linux-stable-d9a5f6a33cd29df9bf8aceda839bdbc4ba3e1152.tar.bz2 linux-stable-d9a5f6a33cd29df9bf8aceda839bdbc4ba3e1152.zip |
net: phylink: avoid mvneta warning when setting pause parameters
[ Upstream commit fd8d9731bcdfb22d28e45bce789bcb211c868c78 ]
mvneta does not support asymetric pause modes, and it flags this by the
lack of AsymPause in the supported field. When setting pause modes, we
check that pause->rx_pause == pause->tx_pause, but only when pause
autoneg is enabled. When pause autoneg is disabled, we still allow
pause->rx_pause != pause->tx_pause, which is incorrect when the MAC
does not support asymetric pause, and causes mvneta to issue a warning.
Fix this by removing the test for pause->autoneg, so we always check
that pause->rx_pause == pause->tx_pause for network devices that do not
support AsymPause.
Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/rtc/rtc-au1xxx.c')
0 files changed, 0 insertions, 0 deletions