diff options
| author | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2018-02-20 23:43:09 +0100 |
|---|---|---|
| committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2018-03-01 10:49:39 +0100 |
| commit | 7d1bd37ff06b9e7c49dc033fce4069f69ad6e564 (patch) | |
| tree | 7cdc99e0efc47f039a9beabda5b57eec1d1cbe8c /drivers/rtc/rtc-ds1553.c | |
| parent | 1c90d9f1c80ba28ddb61c3dbdc55ac686c073d75 (diff) | |
| download | linux-stable-7d1bd37ff06b9e7c49dc033fce4069f69ad6e564.tar.gz linux-stable-7d1bd37ff06b9e7c49dc033fce4069f69ad6e564.tar.bz2 linux-stable-7d1bd37ff06b9e7c49dc033fce4069f69ad6e564.zip | |
rtc: ds1553: let the core handle invalid time
Returning a valid time when the time is invalid is a bad practice, because
then userspace is not able to react on the information. Also, it doesn't
make sense to return epoch because it is already the default time.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Diffstat (limited to 'drivers/rtc/rtc-ds1553.c')
| -rw-r--r-- | drivers/rtc/rtc-ds1553.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/rtc/rtc-ds1553.c b/drivers/rtc/rtc-ds1553.c index 7334c824371a..2441b9a2b366 100644 --- a/drivers/rtc/rtc-ds1553.c +++ b/drivers/rtc/rtc-ds1553.c @@ -127,10 +127,6 @@ static int ds1553_rtc_read_time(struct device *dev, struct rtc_time *tm) /* year is 1900 + tm->tm_year */ tm->tm_year = bcd2bin(year) + bcd2bin(century) * 100 - 1900; - if (rtc_valid_tm(tm) < 0) { - dev_err(dev, "retrieved date/time is not valid.\n"); - rtc_time_to_tm(0, tm); - } return 0; } |