diff options
| author | Paul Kocialkowski <paul.kocialkowski@bootlin.com> | 2019-12-12 16:31:10 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-02-14 16:34:12 -0500 |
| commit | 7a3aa58c0e027b5d7997bee1a64860ddc6059942 (patch) | |
| tree | ab0d1a09e2d1ec6f3d86c9eda8fcfc4025ac82d1 /drivers/rtc/rtc-hym8563.c | |
| parent | ffad5982ce5828b80316673c60f153abf8cfa11b (diff) | |
| download | linux-stable-7a3aa58c0e027b5d7997bee1a64860ddc6059942.tar.gz linux-stable-7a3aa58c0e027b5d7997bee1a64860ddc6059942.tar.bz2 linux-stable-7a3aa58c0e027b5d7997bee1a64860ddc6059942.zip | |
rtc: hym8563: Return -EINVAL if the time is known to be invalid
commit f236a2a2ebabad0848ad0995af7ad1dc7029e895 upstream.
The current code returns -EPERM when the voltage loss bit is set.
Since the bit indicates that the time value is not valid, return
-EINVAL instead, which is the appropriate error code for this
situation.
Fixes: dcaf03849352 ("rtc: add hym8563 rtc-driver")
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Link: https://lore.kernel.org/r/20191212153111.966923-1-paul.kocialkowski@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/rtc/rtc-hym8563.c')
| -rw-r--r-- | drivers/rtc/rtc-hym8563.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c index 443f6d05ce29..fb6d7967ec00 100644 --- a/drivers/rtc/rtc-hym8563.c +++ b/drivers/rtc/rtc-hym8563.c @@ -97,7 +97,7 @@ static int hym8563_rtc_read_time(struct device *dev, struct rtc_time *tm) if (!hym8563->valid) { dev_warn(&client->dev, "no valid clock/calendar values available\n"); - return -EPERM; + return -EINVAL; } ret = i2c_smbus_read_i2c_block_data(client, HYM8563_SEC, 7, buf); |