diff options
| author | Julian Wiedmann <jwi@linux.ibm.com> | 2019-04-17 18:17:30 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-04-17 10:33:59 -0700 |
| commit | fdd1a5303efb03bfa4016f29a519f0e553739069 (patch) | |
| tree | 5dda3a632f0409c468e14e6edd4949b70964dfa6 /drivers/s390 | |
| parent | a4cdc9baee0740748f16e50cd70c2607510df492 (diff) | |
| download | linux-stable-fdd1a5303efb03bfa4016f29a519f0e553739069.tar.gz linux-stable-fdd1a5303efb03bfa4016f29a519f0e553739069.tar.bz2 linux-stable-fdd1a5303efb03bfa4016f29a519f0e553739069.zip | |
s390/qeth: don't bother updating the last-tx time
As the documentation for netif_trans_update() says, netdev_start_xmit()
already updates the last-tx time after every good xmit. So don't
duplicate that effort.
One odd case is that qeth_flush_buffers() also gets called from our
TX completion handler, to flush out any partially filled buffer when
we switch the queue to non-packing mode. But as the TX completion
handler will _always_ wake the txq, we don't have to worry about
the TX watchdog there.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/s390')
| -rw-r--r-- | drivers/s390/net/qeth_core_main.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index ac592d610c5e..9e495df742cb 100644 --- a/drivers/s390/net/qeth_core_main.c +++ b/drivers/s390/net/qeth_core_main.c @@ -3371,7 +3371,6 @@ static void qeth_flush_buffers(struct qeth_qdio_out_q *queue, int index, } QETH_TXQ_STAT_ADD(queue, bufs, count); - netif_trans_update(queue->card->dev); qdio_flags = QDIO_FLAG_SYNC_OUTPUT; if (atomic_read(&queue->set_pci_flags_count)) qdio_flags |= QDIO_FLAG_PCI_OUT; |