diff options
| author | Tong Zhang <ztong0001@gmail.com> | 2021-09-06 21:07:02 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-11-26 11:36:12 +0100 |
| commit | ddb0de839c3477c8c014c461c26a36261319f93c (patch) | |
| tree | e6b87fbd519a7299a6a9890c8149b6dfe694a3d1 /drivers/scsi/dc395x.c | |
| parent | 55a263f43316302636f45bf9338df5f433ec485c (diff) | |
| download | linux-stable-ddb0de839c3477c8c014c461c26a36261319f93c.tar.gz linux-stable-ddb0de839c3477c8c014c461c26a36261319f93c.tar.bz2 linux-stable-ddb0de839c3477c8c014c461c26a36261319f93c.zip | |
scsi: dc395: Fix error case unwinding
[ Upstream commit cbd9a3347c757383f3d2b50cf7cfd03eb479c481 ]
dc395x_init_one()->adapter_init() might fail. In this case, the acb is
already cleaned up by adapter_init(), no need to do that in
adapter_uninit(acb) again.
[ 1.252251] dc395x: adapter init failed
[ 1.254900] RIP: 0010:adapter_uninit+0x94/0x170 [dc395x]
[ 1.260307] Call Trace:
[ 1.260442] dc395x_init_one.cold+0x72a/0x9bb [dc395x]
Link: https://lore.kernel.org/r/20210907040702.1846409-1-ztong0001@gmail.com
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reviewed-by: Finn Thain <fthain@linux-m68k.org>
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/scsi/dc395x.c')
| -rw-r--r-- | drivers/scsi/dc395x.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c index 3943347ec3c7..16b9dc2fff6b 100644 --- a/drivers/scsi/dc395x.c +++ b/drivers/scsi/dc395x.c @@ -4805,6 +4805,7 @@ static int dc395x_init_one(struct pci_dev *dev, const struct pci_device_id *id) /* initialise the adapter and everything we need */ if (adapter_init(acb, io_port_base, io_port_len, irq)) { dprintkl(KERN_INFO, "adapter init failed\n"); + acb = NULL; goto fail; } |