summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/esas2r
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2019-10-22 13:23:24 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-01-23 08:21:38 +0100
commit097f5dfc96ce8ce27d91ae5af6fc8ea45b62b501 (patch)
tree188d5905c671e2d95eee2e73da2d3c983cab3a87 /drivers/scsi/esas2r
parentd28d607908c7a7ab428872fa50871b9bb5bd3450 (diff)
downloadlinux-stable-097f5dfc96ce8ce27d91ae5af6fc8ea45b62b501.tar.gz
linux-stable-097f5dfc96ce8ce27d91ae5af6fc8ea45b62b501.tar.bz2
linux-stable-097f5dfc96ce8ce27d91ae5af6fc8ea45b62b501.zip
scsi: esas2r: unlock on error in esas2r_nvram_read_direct()
commit 906ca6353ac09696c1bf0892513c8edffff5e0a6 upstream. This error path is missing an unlock. Fixes: 26780d9e12ed ("[SCSI] esas2r: ATTO Technology ExpressSAS 6G SAS/SATA RAID Adapter Driver") Link: https://lore.kernel.org/r/20191022102324.GA27540@mwanda Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/scsi/esas2r')
-rw-r--r--drivers/scsi/esas2r/esas2r_flash.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/esas2r/esas2r_flash.c b/drivers/scsi/esas2r/esas2r_flash.c
index 7bd376d95ed5..b02ac389e6c6 100644
--- a/drivers/scsi/esas2r/esas2r_flash.c
+++ b/drivers/scsi/esas2r/esas2r_flash.c
@@ -1197,6 +1197,7 @@ bool esas2r_nvram_read_direct(struct esas2r_adapter *a)
if (!esas2r_read_flash_block(a, a->nvram, FLS_OFFSET_NVR,
sizeof(struct esas2r_sas_nvram))) {
esas2r_hdebug("NVRAM read failed, using defaults");
+ up(&a->nvram_semaphore);
return false;
}