diff options
| author | Jackie Liu <liuyun01@kylinos.cn> | 2022-03-29 10:12:51 +0800 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2022-03-29 23:54:26 -0400 |
| commit | 99241e119f4a2077383f994a174b38ced21d6fca (patch) | |
| tree | fa14979c07e8f4feb591cc0f3d4ae40b06ad002c /drivers/scsi/scsi_sysfs.c | |
| parent | 066f4c31945ce2cb30e840794ee01713dec73b74 (diff) | |
| download | linux-stable-99241e119f4a2077383f994a174b38ced21d6fca.tar.gz linux-stable-99241e119f4a2077383f994a174b38ced21d6fca.tar.bz2 linux-stable-99241e119f4a2077383f994a174b38ced21d6fca.zip | |
scsi: core: sysfs: Remove comments that conflict with the actual logic
Christoph Hellwig Says:
=======================
I think we should just handle the error properly and remove the comment.
There's no good reason to ignore bsg registration errors.
In fact, after commit 92c4b58b15c5 ("scsi: core: Register sysfs attributes
earlier"), we are already forced to return errno.
We discuss this issue in [1].
[1] https://lore.kernel.org/all/20211022010201.426746-1-liu.yun@linux.dev/
Link: https://lore.kernel.org/r/20220329021251.123805-1-liu.yun@linux.dev
Suggested-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/scsi_sysfs.c')
| -rw-r--r-- | drivers/scsi/scsi_sysfs.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index 226a50944c00..dc6872e352bd 100644 --- a/drivers/scsi/scsi_sysfs.c +++ b/drivers/scsi/scsi_sysfs.c @@ -1384,10 +1384,6 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev) if (IS_ENABLED(CONFIG_BLK_DEV_BSG)) { sdev->bsg_dev = scsi_bsg_register_queue(sdev); if (IS_ERR(sdev->bsg_dev)) { - /* - * We're treating error on bsg register as non-fatal, so - * pretend nothing went wrong. - */ error = PTR_ERR(sdev->bsg_dev); sdev_printk(KERN_INFO, sdev, "Failed to register bsg queue, errno=%d\n", |