diff options
| author | Tomas Henzl <thenzl@redhat.com> | 2023-03-24 14:52:49 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-04-26 11:21:51 +0200 |
| commit | 5687c568b4951c4c8a7709ea3202ea3b23d1a010 (patch) | |
| tree | 7e6c4ffafa0ffa3c147d61cf60b5f7efd198f308 /drivers/scsi | |
| parent | 01a51919e23079c7e7ea5e30b5b2d51b2fba4d28 (diff) | |
| download | linux-stable-5687c568b4951c4c8a7709ea3202ea3b23d1a010.tar.gz linux-stable-5687c568b4951c4c8a7709ea3202ea3b23d1a010.tar.bz2 linux-stable-5687c568b4951c4c8a7709ea3202ea3b23d1a010.zip | |
scsi: megaraid_sas: Fix fw_crash_buffer_show()
[ Upstream commit 0808ed6ebbc292222ca069d339744870f6d801da ]
If crash_dump_buf is not allocated then crash dump can't be available.
Replace logical 'and' with 'or'.
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
Link: https://lore.kernel.org/r/20230324135249.9733-1-thenzl@redhat.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/megaraid/megaraid_sas_base.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 8877a21102f1..8d1df03386b4 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -3032,7 +3032,7 @@ megasas_fw_crash_buffer_show(struct device *cdev, spin_lock_irqsave(&instance->crashdump_lock, flags); buff_offset = instance->fw_crash_buffer_offset; - if (!instance->crash_dump_buf && + if (!instance->crash_dump_buf || !((instance->fw_crash_state == AVAILABLE) || (instance->fw_crash_state == COPYING))) { dev_err(&instance->pdev->dev, |