diff options
| author | Zhang Qilong <zhangqilong3@huawei.com> | 2020-11-03 22:13:23 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-12-29 13:44:54 +0100 |
| commit | 2ab91193ba373114ea2ae006e1e7886e6524a20f (patch) | |
| tree | f64d53add76c22dcc95a050042d366a070e48fcc /drivers/spi | |
| parent | d377167daaff440ce70a3bf3eedbf2eb29c110ef (diff) | |
| download | linux-stable-2ab91193ba373114ea2ae006e1e7886e6524a20f.tar.gz linux-stable-2ab91193ba373114ea2ae006e1e7886e6524a20f.tar.bz2 linux-stable-2ab91193ba373114ea2ae006e1e7886e6524a20f.zip | |
spi: tegra20-sflash: fix reference leak in tegra_sflash_resume
[ Upstream commit 3482e797ab688da6703fe18d8bad52f94199f4f2 ]
pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in tegra_sflash_resume, so we should fix it.
Fixes: 8528547bcc336 ("spi: tegra: add spi driver for sflash controller")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201103141323.5841-1-zhangqilong3@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi-tegra20-sflash.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-sflash.c index b6558bb6f9df..4b9541e1726a 100644 --- a/drivers/spi/spi-tegra20-sflash.c +++ b/drivers/spi/spi-tegra20-sflash.c @@ -564,6 +564,7 @@ static int tegra_sflash_resume(struct device *dev) ret = pm_runtime_get_sync(dev); if (ret < 0) { + pm_runtime_put_noidle(dev); dev_err(dev, "pm runtime failed, e = %d\n", ret); return ret; } |