diff options
| author | Jiang Yi <jiangyilism@gmail.com> | 2017-08-11 11:29:44 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-12-20 10:01:32 +0100 |
| commit | 8948ed2f5fe4e6d567ba74426c8de6bdb46f8a1a (patch) | |
| tree | a911e182da087f709a3f323ea6ebc1e1b890ce87 /drivers/target | |
| parent | e6da104cbddcfa80c3afae7be60d259799909431 (diff) | |
| download | linux-stable-8948ed2f5fe4e6d567ba74426c8de6bdb46f8a1a.tar.gz linux-stable-8948ed2f5fe4e6d567ba74426c8de6bdb46f8a1a.tar.bz2 linux-stable-8948ed2f5fe4e6d567ba74426c8de6bdb46f8a1a.zip | |
target/file: Do not return error for UNMAP if length is zero
[ Upstream commit 594e25e73440863981032d76c9b1e33409ceff6e ]
The function fd_execute_unmap() in target_core_file.c calles
ret = file->f_op->fallocate(file, mode, pos, len);
Some filesystems implement fallocate() to return error if
length is zero (e.g. btrfs) but according to SCSI Block
Commands spec UNMAP should return success for zero length.
Signed-off-by: Jiang Yi <jiangyilism@gmail.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/target')
| -rw-r--r-- | drivers/target/target_core_file.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c index 9233b653cc72..98dd0044dca3 100644 --- a/drivers/target/target_core_file.c +++ b/drivers/target/target_core_file.c @@ -592,6 +592,10 @@ fd_do_unmap(struct se_cmd *cmd, void *priv, sector_t lba, sector_t nolb) struct inode *inode = file->f_mapping->host; int ret; + if (!nolb) { + return 0; + } + if (cmd->se_dev->dev_attrib.pi_prot_type) { ret = fd_do_prot_unmap(cmd, lba, nolb); if (ret) |