diff options
| author | Bart Van Assche <bart.vanassche@sandisk.com> | 2017-05-04 15:50:47 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-05-20 14:18:38 +0200 |
| commit | a4fffe4fb974d7571ea9e3c5f9abd05cb953df63 (patch) | |
| tree | 58db19c2bc73cf8746b79426313c0c2dd39e4073 /drivers/target | |
| parent | b3eba07a079ee4b628e40d6fecb44e2bc8f139e8 (diff) | |
| download | linux-stable-a4fffe4fb974d7571ea9e3c5f9abd05cb953df63.tar.gz linux-stable-a4fffe4fb974d7571ea9e3c5f9abd05cb953df63.tar.bz2 linux-stable-a4fffe4fb974d7571ea9e3c5f9abd05cb953df63.zip | |
target/fileio: Fix zero-length READ and WRITE handling
commit 59ac9c078141b8fd0186c0b18660a1b2c24e724e upstream.
This patch fixes zero-length READ and WRITE handling in target/FILEIO,
which was broken a long time back by:
Since:
commit d81cb44726f050d7cf1be4afd9cb45d153b52066
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: Mon Sep 17 16:36:11 2012 -0700
target: go through normal processing for all zero-length commands
which moved zero-length READ and WRITE completion out of target-core,
to doing submission into backend driver code.
To address this, go ahead and invoke target_complete_cmd() for any
non negative return value in fd_do_rw().
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Andy Grover <agrover@redhat.com>
Cc: David Disseldorp <ddiss@suse.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/target')
| -rw-r--r-- | drivers/target/target_core_file.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c index 88c9179ab20f..9233b653cc72 100644 --- a/drivers/target/target_core_file.c +++ b/drivers/target/target_core_file.c @@ -760,8 +760,7 @@ fd_execute_rw(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents, return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; } - if (ret) - target_complete_cmd(cmd, SAM_STAT_GOOD); + target_complete_cmd(cmd, SAM_STAT_GOOD); return 0; } |