summaryrefslogtreecommitdiffstats
path: root/drivers/target
diff options
context:
space:
mode:
authorkernel test robot <lkp@intel.com>2021-05-16 07:03:58 +0800
committerMartin K. Petersen <martin.petersen@oracle.com>2021-05-21 17:14:21 -0400
commit824731258b65f58764786f8d776c2007b084e12c (patch)
tree3746188d772a75a538f182355012740e8f6ba3d8 /drivers/target
parente2ac7ab281c06cd367f6bffc4ba445a311a5f52a (diff)
downloadlinux-stable-824731258b65f58764786f8d776c2007b084e12c.tar.gz
linux-stable-824731258b65f58764786f8d776c2007b084e12c.tar.bz2
linux-stable-824731258b65f58764786f8d776c2007b084e12c.zip
scsi: target: tcmu: Fix boolreturn.cocci warnings
drivers/target/target_core_user.c:1424:9-10: WARNING: return of 0/1 in function 'tcmu_handle_completions' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Link: https://lore.kernel.org/r/20210515230358.GA97544@60d1edce16e0 Fixes: 9814b55cde05 ("scsi: target: tcmu: Return from tcmu_handle_completions() if cmd_id not found") CC: Bodo Stroesser <bostroesser@gmail.com> Reported-by: kernel test robot <lkp@intel.com> Acked-by: Bodo Stroesser <bostroesser@gmail.com> Signed-off-by: kernel test robot <lkp@intel.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/target')
-rw-r--r--drivers/target/target_core_user.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index 9866d7b49ab8..3bbe0a7a5465 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -1421,7 +1421,7 @@ static bool tcmu_handle_completions(struct tcmu_dev *udev)
if (test_bit(TCMU_DEV_BIT_BROKEN, &udev->flags)) {
pr_err("ring broken, not handling completions\n");
- return 0;
+ return false;
}
mb = udev->mb_addr;