summaryrefslogtreecommitdiffstats
path: root/drivers/usb/gadget/function/f_hid.c
diff options
context:
space:
mode:
authorMaxim Devaev <mdevaev@gmail.com>2021-07-27 21:58:00 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-08-12 13:19:42 +0200
commit8b575d820ddac2e959acc9575c55a5d5272fbcee (patch)
treebf753c3fd4a7093f8c7b3d01902f230dc33a2c92 /drivers/usb/gadget/function/f_hid.c
parent1071804cc89e984e0d2c966e890fd37f77a8e951 (diff)
downloadlinux-stable-8b575d820ddac2e959acc9575c55a5d5272fbcee.tar.gz
linux-stable-8b575d820ddac2e959acc9575c55a5d5272fbcee.tar.bz2
linux-stable-8b575d820ddac2e959acc9575c55a5d5272fbcee.zip
usb: gadget: f_hid: idle uses the highest byte for duration
commit fa20bada3f934e3b3e4af4c77e5b518cd5a282e5 upstream. SET_IDLE value must be shifted 8 bits to the right to get duration. This confirmed by USBCV test. Fixes: afcff6dc690e ("usb: gadget: f_hid: added GET_IDLE and SET_IDLE handlers") Cc: stable <stable@vger.kernel.org> Signed-off-by: Maxim Devaev <mdevaev@gmail.com> Link: https://lore.kernel.org/r/20210727185800.43796-1-mdevaev@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/gadget/function/f_hid.c')
-rw-r--r--drivers/usb/gadget/function/f_hid.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c
index f9fe94d1764a..1d10d29c115b 100644
--- a/drivers/usb/gadget/function/f_hid.c
+++ b/drivers/usb/gadget/function/f_hid.c
@@ -579,7 +579,7 @@ static int hidg_setup(struct usb_function *f,
| HID_REQ_SET_IDLE):
VDBG(cdev, "set_idle\n");
length = 0;
- hidg->idle = value;
+ hidg->idle = value >> 8;
goto respond;
break;