diff options
| author | Alan Cox <alan@redhat.com> | 2009-01-02 13:48:56 +0000 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-01-02 10:19:42 -0800 |
| commit | 6b447f04a9aecdf2a30c1a97e4b034ac7931bb70 (patch) | |
| tree | 61a92b936c0c8e42ebf93e01acbc15aceb9bd864 /drivers/usb/serial/mct_u232.c | |
| parent | eeb4613436f0f19a38f667ea3078821040559c68 (diff) | |
| download | linux-stable-6b447f04a9aecdf2a30c1a97e4b034ac7931bb70.tar.gz linux-stable-6b447f04a9aecdf2a30c1a97e4b034ac7931bb70.tar.bz2 linux-stable-6b447f04a9aecdf2a30c1a97e4b034ac7931bb70.zip | |
tty: Drop the lock_kernel in the private ioctl hook
We don't need the BKL here any more so it can go. In a couple of spots the
driver requirements are not clear so push the lock down into the driver.
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/usb/serial/mct_u232.c')
| -rw-r--r-- | drivers/usb/serial/mct_u232.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c index 07710cf31d0d..82930a7d5093 100644 --- a/drivers/usb/serial/mct_u232.c +++ b/drivers/usb/serial/mct_u232.c @@ -721,10 +721,10 @@ static void mct_u232_break_ctl(struct tty_struct *tty, int break_state) spin_lock_irqsave(&priv->lock, flags); lcr = priv->last_lcr; - spin_unlock_irqrestore(&priv->lock, flags); if (break_state) lcr |= MCT_U232_SET_BREAK; + spin_unlock_irqrestore(&priv->lock, flags); mct_u232_set_line_ctrl(serial, lcr); } /* mct_u232_break_ctl */ |