diff options
| author | Johan Hovold <johan@kernel.org> | 2017-03-06 17:36:38 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-04-18 07:55:50 +0200 |
| commit | d064efcbd6ed7526ad075a9ad5ef28b1d398ab46 (patch) | |
| tree | 5a347df6bb703434f6372a54caeb8e669db5b084 /drivers/usb/serial | |
| parent | f75a177da244fe3712d9892af8dff137fc109dbc (diff) | |
| download | linux-stable-d064efcbd6ed7526ad075a9ad5ef28b1d398ab46.tar.gz linux-stable-d064efcbd6ed7526ad075a9ad5ef28b1d398ab46.tar.bz2 linux-stable-d064efcbd6ed7526ad075a9ad5ef28b1d398ab46.zip | |
USB: serial: omninet: fix reference leaks at open
commit 30572418b445d85fcfe6c8fe84c947d2606767d8 upstream.
This driver needlessly took another reference to the tty on open, a
reference which was then never released on close. This lead to not just
a leak of the tty, but also a driver reference leak that prevented the
driver from being unloaded after a port had once been opened.
Fixes: 4a90f09b20f4 ("tty: usb-serial krefs")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/serial')
| -rw-r--r-- | drivers/usb/serial/omninet.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c index f6c6900bccf0..880bbdba19d2 100644 --- a/drivers/usb/serial/omninet.c +++ b/drivers/usb/serial/omninet.c @@ -129,12 +129,6 @@ static int omninet_port_remove(struct usb_serial_port *port) static int omninet_open(struct tty_struct *tty, struct usb_serial_port *port) { - struct usb_serial *serial = port->serial; - struct usb_serial_port *wport; - - wport = serial->port[1]; - tty_port_tty_set(&wport->port, tty); - return usb_serial_generic_open(tty, port); } |