diff options
| author | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> | 2017-06-20 11:38:02 +0200 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2017-10-12 15:28:02 +0100 |
| commit | deebb33450ede9b554962bdad8556a2b50cc4f1f (patch) | |
| tree | 30de98e2ccdd207d357f6a0bfa26dbcc2ac6f23c /drivers | |
| parent | 20f57a543a03dca09c6012c6ad6acd212b345d82 (diff) | |
| download | linux-stable-deebb33450ede9b554962bdad8556a2b50cc4f1f.tar.gz linux-stable-deebb33450ede9b554962bdad8556a2b50cc4f1f.tar.bz2 linux-stable-deebb33450ede9b554962bdad8556a2b50cc4f1f.zip | |
tpm: fix a kernel memory leak in tpm-sysfs.c
commit 13b47cfcfc60495cde216eef4c01040d76174cbe upstream.
While cleaning up sysfs callback that prints EK we discovered a kernel
memory leak. This commit fixes the issue by zeroing the buffer used for
TPM command/response.
The leak happen when we use either tpm_vtpm_proxy, tpm_ibmvtpm or
xen-tpmfront.
Fixes: 0883743825e3 ("TPM: sysfs functions consolidation")
Reported-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Tested-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/char/tpm/tpm-sysfs.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/char/tpm/tpm-sysfs.c b/drivers/char/tpm/tpm-sysfs.c index 01730a27ae07..994fb055e99d 100644 --- a/drivers/char/tpm/tpm-sysfs.c +++ b/drivers/char/tpm/tpm-sysfs.c @@ -54,9 +54,10 @@ static ssize_t pubek_show(struct device *dev, struct device_attribute *attr, ssize_t err; int i, rc; char *str = buf; - struct tpm_chip *chip = dev_get_drvdata(dev); + memset(&tpm_cmd, 0, sizeof(tpm_cmd)); + tpm_cmd.header.in = tpm_readpubek_header; err = transmit_cmd(chip, &tpm_cmd, READ_PUBEK_RESULT_SIZE, "attempting to read the PUBEK"); |