diff options
| author | Axel Lin <axel.lin@ingics.com> | 2014-07-30 11:13:52 +0800 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2014-09-13 23:41:40 +0100 |
| commit | 395166a4a56a41c221271211a914cf04436a893d (patch) | |
| tree | ac8e155dcb214dc384265be58b971535bcca6a11 /drivers | |
| parent | 0f7e814c5af6ce77732ec0ccf3be31ac8aa6b1c4 (diff) | |
| download | linux-stable-395166a4a56a41c221271211a914cf04436a893d.tar.gz linux-stable-395166a4a56a41c221271211a914cf04436a893d.tar.bz2 linux-stable-395166a4a56a41c221271211a914cf04436a893d.zip | |
hwmon: (ads1015) Fix off-by-one for valid channel index checking
commit 56de1377ad92f72ee4e5cb0faf7a9b6048fdf0bf upstream.
Current code uses channel as array index, so the valid channel value is
0 .. ADS1015_CHANNELS - 1.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/hwmon/ads1015.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c index dd87ae96c262..c9780ae1a54c 100644 --- a/drivers/hwmon/ads1015.c +++ b/drivers/hwmon/ads1015.c @@ -186,7 +186,7 @@ static int ads1015_get_channels_config_of(struct i2c_client *client) } channel = be32_to_cpup(property); - if (channel > ADS1015_CHANNELS) { + if (channel >= ADS1015_CHANNELS) { dev_err(&client->dev, "invalid channel index %d on %s\n", channel, node->full_name); |