diff options
| author | Sergey Shtylyov <s.shtylyov@omp.ru> | 2021-07-04 17:45:25 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-09-22 11:47:54 +0200 |
| commit | 92680bc8f0b2f0c90590cab16505e1892b700ed7 (patch) | |
| tree | ecd7bc2171129871d3f93bbfef3d4c47fa9d40c4 /drivers | |
| parent | e4491423690e385d8db669e1b4f299b2c60e3e5e (diff) | |
| download | linux-stable-92680bc8f0b2f0c90590cab16505e1892b700ed7.tar.gz linux-stable-92680bc8f0b2f0c90590cab16505e1892b700ed7.tar.bz2 linux-stable-92680bc8f0b2f0c90590cab16505e1892b700ed7.zip | |
i2c: s3c2410: fix IRQ check
[ Upstream commit d6840a5e370b7ea4fde16ce2caf431bcc87f9a75 ]
Iff platform_get_irq() returns 0, the driver's probe() method will return 0
early (as if the method's call was successful). Let's consider IRQ0 valid
for simplicity -- devm_request_irq() can always override that decision...
Fixes: e0d1ec97853f ("i2c-s3c2410: Change IRQ to be plain integer.")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/i2c/busses/i2c-s3c2410.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index d3603e261a84..4c6036920388 100644 --- a/drivers/i2c/busses/i2c-s3c2410.c +++ b/drivers/i2c/busses/i2c-s3c2410.c @@ -1179,7 +1179,7 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) */ if (!(i2c->quirks & QUIRK_POLL)) { i2c->irq = ret = platform_get_irq(pdev, 0); - if (ret <= 0) { + if (ret < 0) { dev_err(&pdev->dev, "cannot find IRQ\n"); clk_unprepare(i2c->clk); return ret; |