diff options
| author | Marc Kleine-Budde <mkl@pengutronix.de> | 2015-07-11 21:16:08 +0200 |
|---|---|---|
| committer | Marc Kleine-Budde <mkl@pengutronix.de> | 2015-07-15 09:04:27 +0200 |
| commit | 05c4456538e9551b8ac47762b21127bf9cf6cc8e (patch) | |
| tree | 6aea4196beb63468318ed8bf3e1bdd38a332b3db /drivers | |
| parent | a2e78cf7a3f562edca4230b188c8832b6214eccd (diff) | |
| download | linux-stable-05c4456538e9551b8ac47762b21127bf9cf6cc8e.tar.gz linux-stable-05c4456538e9551b8ac47762b21127bf9cf6cc8e.tar.bz2 linux-stable-05c4456538e9551b8ac47762b21127bf9cf6cc8e.zip | |
can: ti_heccn: don't touch skb after netif_rx()
There is no guarantee that the skb is in the same state after calling
net_receive_skb() or netif_rx(). It might be freed or reused. Not really
harmful as its a read access, except you turn on the proper debugging options
which catch a use after free.
Cc: Anant Gole <anantgole@ti.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/can/ti_hecc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c index e95a9e1a889f..cf345cbfe819 100644 --- a/drivers/net/can/ti_hecc.c +++ b/drivers/net/can/ti_hecc.c @@ -747,9 +747,9 @@ static int ti_hecc_error(struct net_device *ndev, int int_status, } } - netif_rx(skb); stats->rx_packets++; stats->rx_bytes += cf->can_dlc; + netif_rx(skb); return 0; } |