diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-06-01 12:09:29 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-06-22 14:13:18 +0200 |
| commit | 506a88a5bf261d76a5214c0338a320f2214c67ac (patch) | |
| tree | ef7620f79e88beaa821e5764f77aa117e1cdac4e /drivers | |
| parent | 7c9dd9d23f26dabcfb14148b9acdfba540418b19 (diff) | |
| download | linux-stable-506a88a5bf261d76a5214c0338a320f2214c67ac.tar.gz linux-stable-506a88a5bf261d76a5214c0338a320f2214c67ac.tar.bz2 linux-stable-506a88a5bf261d76a5214c0338a320f2214c67ac.zip | |
irqchip/gic-v3: Fix refcount leak in gic_populate_ppi_partitions
[ Upstream commit fa1ad9d4cc47ca2470cd904ad4519f05d7e43a2b ]
of_find_node_by_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: e3825ba1af3a ("irqchip/gic-v3: Add support for partitioned PPIs")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220601080930.31005-6-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/irqchip/irq-gic-v3.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 8d62028a0e04..4c8f18f0cecf 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -1872,12 +1872,15 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node) continue; cpu = of_cpu_node_to_id(cpu_node); - if (WARN_ON(cpu < 0)) + if (WARN_ON(cpu < 0)) { + of_node_put(cpu_node); continue; + } pr_cont("%pOF[%d] ", cpu_node, cpu); cpumask_set_cpu(cpu, &part->mask); + of_node_put(cpu_node); } pr_cont("}\n"); |